Yabeda integration for prom metrics #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngetahun
added
enhancement
josegomezr
reviewed
Oct 29, 2024
…tings.dig for metrics.enabled
ngetahun
changed the title
ngetahun
changed the title
digitaltom
reviewed
Nov 4, 2024
digitaltom
reviewed
Nov 4, 2024
felixsch
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
lgtm 👍
I'm not really sure what is the scope. The metric export now most information, I hope this is fine.
How I reviewed this merge request:
- Checked the code changes make sense to me
- Ran the branch and checked
/metricsis populated (also in error case)
As always, if you think I missed something I should test, please let me know!🚀
cheers,
This reverts commit 63119c3.
josegomezr
reviewed
Nov 4, 2024
Error gets built automagically by rspec,
no need to { error: <string> }.to_json
Expect was too granular and specific
ngetahun
force-pushed
the
test_yabeda
branch
2 times, most recently
from
50df6dc to
384b00b
Compare
digitaltom
reviewed
Nov 7, 2024
digitaltom
reviewed
Nov 7, 2024
digitaltom
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How to test
Start the rails server:
> bin/rails sOn a separate console, run:
> curl localhost:4224/metricsShould see a text with metrics and values
Change Type
Please select the correct option.
Checklist
Please check off each item if the requirement is met.
MANUAL.mdfile with any changes to the user experience.package/obs/rmt-server.changes.Review
Please check out our review guidelines
and get in touch with the author to get a shared understanding of the change.